svn commit: r298377 - head/sys/dev/acpica

John Baldwin jhb at freebsd.org
Wed Apr 20 22:27:27 UTC 2016


On Wednesday, April 20, 2016 09:21:47 PM Jung-uk Kim wrote:
> Author: jkim
> Date: Wed Apr 20 21:21:47 2016
> New Revision: 298377
> URL: https://svnweb.freebsd.org/changeset/base/298377
> 
> Log:
>   Remove query flag from acpi_EvaluateOSC().  This function does not support
>   return buffer (yet).

Hmm, I should probably fix that then instead?  The PCI variant is (now)
incorrectly assuming it gets the buffer back in the array it passed in.
The 5.0 spec at least says that the returned values are identical in
length to the array passed in.  We could either add a new parameter for
the outputs or copy them to the inputs.  Perhaps the former is better?

I'd still prefer to set caps[0] in the common code since it is not
UUID-specific but something all _OSC callers have to do.

-- 
John Baldwin


More information about the svn-src-head mailing list