svn commit: r254185 - head/sys/modules/random

[Konstantin Belousov]

On Sat, Aug 10, 2013 at 12:27:54PM -0700, Peter Wemm wrote:
> On Sat, Aug 10, 2013 at 11:23 AM, Konstantin Belousov <kib at freebsd.org> wrote:
> > Author: kib
> > Date: Sat Aug 10 18:23:28 2013
> > New Revision: 254185
> > URL: http://svnweb.freebsd.org/changeset/base/254185
> >
> > Log:
> >   Restore the ability to kldload random.ko, by linking in the newly
> >   added random_adaptors.c.
> >
> > Modified:
> >   head/sys/modules/random/Makefile
> >
> > Modified: head/sys/modules/random/Makefile
> > ==============================================================================
> > --- head/sys/modules/random/Makefile    Sat Aug 10 18:23:18 2013        (r254184)
> > +++ head/sys/modules/random/Makefile    Sat Aug 10 18:23:28 2013        (r254185)
> > @@ -5,7 +5,7 @@
> >  .PATH: ${.CURDIR}/../../crypto/sha2
> >
> >  KMOD=  random
> > -SRCS=  randomdev.c probe.c
> > +SRCS=  randomdev.c random_adaptors.c probe.c
> >  .if ${MACHINE} == "amd64" || ${MACHINE} == "i386"
> >  SRCS+= nehemiah.c
> >  SRCS+= ivy.c
> 
> However, random_adapters.c is "standard":
> # grep random files
> dev/random/harvest.c		standard
> dev/random/hash.c		optional random
> dev/random/probe.c		optional random
> dev/random/random_adaptors.c	standard
> dev/random/randomdev.c		optional random
> dev/random/randomdev_soft.c	optional random
> dev/random/yarrow.c		optional random
> 
> I understand why harvest.c is standard - it's called by drivers.  But
> wouldn't your change to the module above duplicate the module list
> into two separate namespaces?

Oops, my change is wrong.  Apparently, I did not re-configured my kernel
where the random.ko module failed the load.

Reverting now, thank you for noticing.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 834 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-src-head/attachments/20130810/e13e6edc/attachment.sig>