svn commit: r254185 - head/sys/modules/random

[Peter Wemm]

On Sat, Aug 10, 2013 at 11:23 AM, Konstantin Belousov <kib at freebsd.org> wrote:
> Author: kib
> Date: Sat Aug 10 18:23:28 2013
> New Revision: 254185
> URL: http://svnweb.freebsd.org/changeset/base/254185
>
> Log:
>   Restore the ability to kldload random.ko, by linking in the newly
>   added random_adaptors.c.
>
> Modified:
>   head/sys/modules/random/Makefile
>
> Modified: head/sys/modules/random/Makefile
> ==============================================================================
> --- head/sys/modules/random/Makefile    Sat Aug 10 18:23:18 2013        (r254184)
> +++ head/sys/modules/random/Makefile    Sat Aug 10 18:23:28 2013        (r254185)
> @@ -5,7 +5,7 @@
>  .PATH: ${.CURDIR}/../../crypto/sha2
>
>  KMOD=  random
> -SRCS=  randomdev.c probe.c
> +SRCS=  randomdev.c random_adaptors.c probe.c
>  .if ${MACHINE} == "amd64" || ${MACHINE} == "i386"
>  SRCS+= nehemiah.c
>  SRCS+= ivy.c

However, random_adapters.c is "standard":
# grep random files
dev/random/harvest.c		standard
dev/random/hash.c		optional random
dev/random/probe.c		optional random
dev/random/random_adaptors.c	standard
dev/random/randomdev.c		optional random
dev/random/randomdev_soft.c	optional random
dev/random/yarrow.c		optional random

I understand why harvest.c is standard - it's called by drivers.  But
wouldn't your change to the module above duplicate the module list
into two separate namespaces?
-- 
Peter Wemm - peter at wemm.org; peter at FreeBSD.org; peter at yahoo-inc.com; KI6FJV
UTF-8: for when a ' just won\342\200\231t do.
<brueffer> ZFS must be the bacon of file systems. "everything's better with ZFS"