svn commit: r220059 - head/usr.sbin/pc-sysinstall/backend

Warner Losh imp at bsdimp.com
Sun Mar 27 22:32:45 UTC 2011


On Mar 27, 2011, at 11:22 AM, Doug Barton wrote:

> On 03/27/2011 09:57, Josh Paetzel wrote:
>>   Replace "$?" = "0" with $? -eq 0 in tests
> 
> Excellent!

Most of the time I've found that moving the command up to the if makes the code clearer too.  At jobs I've had in the past when I've written code similar to what we have here, it almost always got flagged...

Warner



More information about the svn-src-head mailing list