svn commit: r220059 - head/usr.sbin/pc-sysinstall/backend

[Doug Barton]

On 03/27/2011 09:57, Josh Paetzel wrote:
> Log:
>    Fix a syntax error in a little-used function.

Since this is unique vs. all the other changes, IMO it should have been 
a separate commit. It doesn't hurt anything to split things up into 
multiple commits, and often helps make things more understandable down 
the road.

>    Replace expr with $(())
>    Replace tests for ! -z with -n

Good. :)

>    Replace grep>  /dev/null with grep -q
>    Consolidate export statements with variable assignment

These 2 make the code slightly less portable, but in this case I don't 
think that's a problem at all.

>    Replace "$?" = "0" with $? -eq 0 in tests

Excellent!


hth,

Doug

-- 

	Nothin' ever doesn't change, but nothin' changes much.
			-- OK Go

	Breadth of IT experience, and depth of knowledge in the DNS.
	Yours for the right price.  :)  http://SupersetSolutions.com/