svn commit: r367651 - head/usr.sbin/bhyve

[Ravi Pokala]

-----Original Message-----
From: <owner-src-committers at freebsd.org> on behalf of Jessica Clarke <jrtc27 at freebsd.org>
Date: 2020-11-13, Friday at 16:53
To: Ravi Pokala <rpokala at freebsd.org>
Cc: Rebecca Cran <bcran at FreeBSD.org>, <src-committers at freebsd.org>, <svn-src-all at freebsd.org>, <svn-src-head at freebsd.org>
Subject: Re: svn commit: r367651 - head/usr.sbin/bhyve

    On 14 Nov 2020, at 00:47, Ravi Pokala <rpokala at freebsd.org> wrote:
    > 
    >>   +#define FIRMWARE_RELEASE_DATE	"11/10/2020"
    > 
    > Might I suggest "2020-11-10", as sorting, logic, ${DEITY}, and ISO-8601 demand? ;-)

    Alas that is a "feature" of the specification:

      String number of the BIOS release date. The date string, if supplied,
      is in either mm/dd/yy or mm/dd/yyyy format. If the year portion of the
      string is two digits, the year is assumed to be 19yy.

      NOTE: The mm/dd/yyyy format is required for SMBIOS version 2.3 and
      later.

    (SMBIOS Specification version 3.4.0c)

<sigh>

Yeah, it occurred to me that it might be something like that shortly after I hit "send". :-p

    It might be worth putting a comment in so people don't accidentally
    change it to the wrong thing in future though, given it's currently
    ambiguous otherwise.

That would be appreciated.

Thanks,

Ravi (rpokala@)

    Jess