svn commit: r367651 - head/usr.sbin/bhyve

Jessica Clarke jrtc27 at freebsd.org
Sat Nov 14 00:53:11 UTC 2020


On 14 Nov 2020, at 00:47, Ravi Pokala <rpokala at freebsd.org> wrote:
> 
>>   +#define FIRMWARE_RELEASE_DATE	"11/10/2020"
> 
> Might I suggest "2020-11-10", as sorting, logic, ${DEITY}, and ISO-8601 demand? ;-)

Alas that is a "feature" of the specification:

  String number of the BIOS release date. The date string, if supplied,
  is in either mm/dd/yy or mm/dd/yyyy format. If the year portion of the
  string is two digits, the year is assumed to be 19yy.

  NOTE: The mm/dd/yyyy format is required for SMBIOS version 2.3 and
  later.

(SMBIOS Specification version 3.4.0c)

It might be worth putting a comment in so people don't accidentally
change it to the wrong thing in future though, given it's currently
ambiguous otherwise.

Jess



More information about the svn-src-all mailing list