svn commit: r364321 - head/sbin/ipfw

[Rodney W. Grimes]

> Hrm, it seems this reply ended up in my spam folder; sorry for not
> replying until now.

lol Oh, bad filter :-)

> > >                       *strchr(timestr, '\n') = '\0';
> > >                       bprintf(bp, "%s ", timestr);
> >                                        ^ Isnt this the +1 space?
> >
> > >               } else {
> > > -                     bprintf(bp, "%*s", twidth, " ");
> > > +                     bprintf(bp, "%*s", twidth + 1, " ");
> >                                         ^missing from this string?
> 
> Inserting an extra space in the format string would also work, sure. I
> considered doing it that way but in the end decided it's not
> materially more clear one way or another, so used the patch as
> submitted.

For me the + 1 leads to a "why is this here", where as the space
in the format string clearly matches the other condition of the else.
Also + 1 causes a run time computation, the extra space does not.


-- 
Rod Grimes                                                 rgrimes at freebsd.org