svn commit: r364321 - head/sbin/ipfw

Ed Maste emaste at freebsd.org
Mon Aug 31 01:33:49 UTC 2020


Hrm, it seems this reply ended up in my spam folder; sorry for not
replying until now.

> >                       *strchr(timestr, '\n') = '\0';
> >                       bprintf(bp, "%s ", timestr);
>                                        ^ Isnt this the +1 space?
>
> >               } else {
> > -                     bprintf(bp, "%*s", twidth, " ");
> > +                     bprintf(bp, "%*s", twidth + 1, " ");
>                                         ^missing from this string?

Inserting an extra space in the format string would also work, sure. I
considered doing it that way but in the end decided it's not
materially more clear one way or another, so used the patch as
submitted.


More information about the svn-src-all mailing list