svn commit: r344487 - in head/sys: conf gnu/gcov

Brooks Davis brooks at
Mon Feb 25 17:58:21 UTC 2019

On Sat, Feb 23, 2019 at 09:14:00PM +0000, Matt Macy wrote:
> Author: mmacy
> Date: Sat Feb 23 21:14:00 2019
> New Revision: 344487
> URL:
> Log:
>   gcov support
>   add gcov support and export results as files in debugfs

We had a brief discussion of this commit within a subset of core.  This
addition of GPLv2 code is fine as the code is easily removal to a module
(per kmoore@) should the day come that we're read to evict all GPL code.
The modest increase in activation energy for that task seems worth it
for the short-term gains of reduced integration cost (this code will
greatly improve our ZFS-on-Linux test coverage.)

Rod rightly points out that we haven't accepted SPDX tags alone as
license statements.  The standard GPL v2.0 boiler plate should be added
to this file along side the tag.

An additional issue is that the a warning tag was not added to
sys/conf/files.  A warning along the lines of:

	warning "kernel contains GPLv2 licensed GCOV"

needs to be added.

This commit needed more through review.

We intend to update our license policy to require core sign off for
new GPL code to ensure we're not adding new, tightly integrated
dependencies, to document that we're doing so knowingly, and
to make sure steps aren't missed.  The current document is at:

-- Brooks
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 455 bytes
Desc: not available
URL: <>

More information about the svn-src-all mailing list