svn commit: r344051 - in stable/12/sbin: newfs tunefs
Cy.Schubert at cschubert.com
Tue Feb 12 16:45:10 UTC 2019
In message <CANCZdfoghrVR3uMQM3oqzv31g732iOHJP=iEeO2qD8kbgUwVrw at mail.gma
, Warner Losh writes:
> Content-Type: text/plain; charset="UTF-8"
> On Tue, Feb 12, 2019 at 9:21 AM Rodney W. Grimes <
> freebsd at pdx.rh.cn85.dnsmgr.net> wrote:
> > > On Tue, 12 Feb 2019, Cy Schubert wrote:
> > >
> > > > In message <201902121358.x1CDwGf9047873 at repo.freebsd.org>, Dmitry
> > > > Morozovsky wr
> > > > ites:
> > > > > Author: marck (doc committer)
> > > > > Date: Tue Feb 12 13:58:16 2019
> > > > > New Revision: 344051
> > > > > URL: https://svnweb.freebsd.org/changeset/base/344051
> > > > >
> > > > > Log:
> > > > > MFC 343548:
> > > > >
> > > > > Allow dashes as a valid character in UFS labels.
> > > >
> > > > Approved by: Whom?
> > >
> > > Sorry, I missed commit log metadata from the original change.
> > >
> > > Lesson learnt.
> > I think your fine on how you did this, I certainly already
> > knew from reading the ^head commits that this change had
> > infact been approved by Kirk, and had been flagged for MFC.
> > I do not see value in duplicationg all that info in the
> > stable branches, but perhaps we should formalize that in
> > the committers guide on commit messages?
> Let's not overreact. Someone made a commit, someone else didn't go check
> the original commit to see it was legit and asked a question. The original
> bonafides were provided. Case closed. No need to make a federal case out of
> it. The doc committer learned to take a little extra care on their commit
> messages, it seems, as doc committers committing to src get a little extra
> scrutiny. The original complainer likely noticed the info was in the
> original commit and may check there in the future before complaining. Or
> maybe he won't. It isn't a big deal either way.
I, the original complainer, noticed a commit by a doc committer without
approval by a src committer.
> None of this requires a change to the rules.
Agreed. No rules need to be changed. It's not a big deal. At the time
the question was about, something was missed or someone did something
that they didn't have authority to do. The question was answered a
couple of hours ago. We can stop bikeshedding this to try to create
more rules when none are required. It was a simple, who authorized this
commit? We got our answer. Let's move on.
Cy Schubert <Cy.Schubert at cschubert.com>
FreeBSD UNIX: <cy at FreeBSD.org> Web: http://www.FreeBSD.org
The need of the many outweighs the greed of the few.
More information about the svn-src-all