svn commit: r328257 - in head/sys: arm/broadcom/bcm2835 dts/arm modules

[Poul-Henning Kamp]

--------
In message <20180122135905.203e19ce94510854777dff63 at bidouilliste.com>, Emmanuel
 Vadot writes:

>> +#if 0
>> +	// XXX: default state is disabled in RPI3 DTB, assume for now
>> +	// XXX: that people want the PWM to work if the KLD this module.
>>  	if (!ofw_bus_status_okay(dev))
>>  		return (ENXIO);
>> +#endif
>
> This is really bad, one need to use overlay to enable the node.
> Leaving this I will predict that in the near futur you will have
>someone complaining that he set to load the module at boot, unplug is
>pwm testing gear and plug another type of HAT and that it makes funny
>thing.

As long as you don't set any of dev.pwm.0.* sysctls, the bcm283x_pwm
driver doesn't do anything, so that situation is harmless.

> Can you please revert this part ?

Once I find out how to get similar behaviour, ie: kldload without
having to reboot to load a DT-overlay.

My preference would be that DT-overlays could be compiled into
kmods, but I'm fine with any reasonable commahd that can load
an overlay without a reboot.

Or alternatively, a command which will change the "status=disable"
to "status=okay" in the already loaded DT ?

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk at FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.