svn commit: r328257 - in head/sys: arm/broadcom/bcm2835 dts/arm modules

[Emmanuel Vadot]

On Mon, 22 Jan 2018 07:10:30 +0000 (UTC)
Poul-Henning Kamp <phk at FreeBSD.org> wrote:

> Author: phk
> Date: Mon Jan 22 07:10:30 2018
> New Revision: 328257
> URL: https://svnweb.freebsd.org/changeset/base/328257
> 
> Log:
>   Add a skeleton Clock Manager for RPi2/3, and use that from pwm
>   instead of frobbing the registers directly.
>   
>   As a hack the bcm2835_pwm kmod presently ignores the 'status="disabled"'
>   in the RPI3 DTB, assuming that if you load the kld you probably
>   want the PWM to work.
> 
> Added:
>   head/sys/arm/broadcom/bcm2835/bcm2835_clkman.c   (contents, props changed)
>   head/sys/arm/broadcom/bcm2835/bcm2835_clkman.h   (contents, props changed)
> Modified:
>   head/sys/arm/broadcom/bcm2835/bcm2835_pwm.c
>   head/sys/dts/arm/bcm2836.dtsi
>   head/sys/modules/Makefile
> 
>  bcm_pwm_probe(device_t dev)
>  {
>  
> +#if 0
> +	// XXX: default state is disabled in RPI3 DTB, assume for now
> +	// XXX: that people want the PWM to work if the KLD this module.
>  	if (!ofw_bus_status_okay(dev))
>  		return (ENXIO);
> +#endif

 This is really bad, one need to use overlay to enable the node.
 Leaving this I will predict that in the near futur you will have
someone complaining that he set to load the module at boot, unplug is
pwm testing gear and plug another type of HAT and that it makes funny
thing.
 Can you please revert this part ?

-- 
Emmanuel Vadot <manu at bidouilliste.com> <manu at freebsd.org>