svn commit: r308996 - head/lib/libfetch

[Baptiste Daroussin]

On Fri, Mar 03, 2017 at 01:29:26PM +0100, Dag-Erling Smørgrav wrote:
> "Bjoern A. Zeeb" <bzeeb-lists at lists.zabbadoz.net> writes:
> > Dag-Erling Smørgrav <des at des.no> writes:
> >> +	/* split address if necessary */
> >> +	err = EAI_SYSTEM;
> >> +	if ((sep = strchr(addr, ':')) != NULL) {
> >> +		len = snprintf(hbuf, sizeof(hbuf),
> >> +		    "%.*s", (int)(sep - addr), addr);
> > I believe this code is what broke
> > 	fetch http://[::1]:6666/
> > just to give an example;  and the printf traces will not reveal this
> > but “addr” at this point has no more addr:port in it given the
> > function arguments, right?
> 
> I think you're right, I'll look into it.  It means replacing strchr()
> with a loop.  Is there a ticket for this bug, and if not, could you
> please open one?
> 

This causes breakage on the cluster for everything using libfetch:

On the jenkins cluster we cannot run anymore fetch inside i386 chroots
# chroot ufs fetch -v http://pkg.freebsd.org
resolving server address: pkg.freebsd.org:80
fetch: http://pkg.freebsd.org: Non-recoverable resolver failure

What is specific is the host only have ipv6 is amd64 and the chroot is i386

I can't figure out the issue can you have a look?

Best regards,
Bapt
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-src-all/attachments/20170312/fb49f2c2/attachment.sig>