svn commit: r308996 - head/lib/libfetch

Dag-Erling Smørgrav des at des.no
Fri Mar 3 12:29:29 UTC 2017


"Bjoern A. Zeeb" <bzeeb-lists at lists.zabbadoz.net> writes:
> Dag-Erling Smørgrav <des at des.no> writes:
>> +	/* split address if necessary */
>> +	err = EAI_SYSTEM;
>> +	if ((sep = strchr(addr, ':')) != NULL) {
>> +		len = snprintf(hbuf, sizeof(hbuf),
>> +		    "%.*s", (int)(sep - addr), addr);
> I believe this code is what broke
> 	fetch http://[::1]:6666/
> just to give an example;  and the printf traces will not reveal this
> but “addr” at this point has no more addr:port in it given the
> function arguments, right?

I think you're right, I'll look into it.  It means replacing strchr()
with a loop.  Is there a ticket for this bug, and if not, could you
please open one?

DES
-- 
Dag-Erling Smørgrav - des at des.no


More information about the svn-src-all mailing list