svn commit: r277213 - in head: share/man/man9 sys/kern sys/ofed/include/linux sys/sys

Ed Maste emaste at freebsd.org
Tue Jan 20 14:23:00 UTC 2015


On 15 January 2015 at 13:53, John Baldwin <jhb at freebsd.org> wrote:
>
> I think it's been a
> clear practice with all other changes reviewed in phabric to date that
> the committer only lists people in 'Reviewed by' who actually signed off
> on the patch, not just the list of people asked to review it.

This point is worth repeating. Phabricator is an add-on tool to aid in
pre-commit review, but is not a required part of our process and
doesn't change the meaning of commit message metadata fields.

"Reviewed by" in a commit message means exactly what it always has:
that those listed have reasonably carefully reviewed the change and
are willing to put their name on it.


More information about the svn-src-all mailing list