svn commit: r277213 - in head: share/man/man9 sys/kern sys/ofed/include/linux sys/sys

John Baldwin jhb at FreeBSD.org
Thu Jan 15 18:53:44 UTC 2015


On 1/15/15 12:15 PM, Gleb Smirnoff wrote:
> On Thu, Jan 15, 2015 at 08:14:30PM +0300, Gleb Smirnoff wrote:
> T> I'd dare to say that such important change simply cannot be committed
> T> with a thorough review from at least two people very confident in this
> T> area.
> 
> Of course, I typoed. I meant "cannot be committed withOUT a thorough review".

There is something to be said for people taking time to review things
and not wanting to be held up forever.  However, I think it's been a
clear practice with all other changes reviewed in phabric to date that
the committer only lists people in 'Reviewed by' who actually signed off
on the patch, not just the list of people asked to review it.

-- 
John Baldwin


More information about the svn-src-all mailing list