svn commit: r251058 - head

[Glen Barber]

On Tue, May 28, 2013 at 01:04:56PM -0700, Peter Wemm wrote:
> On Tue, May 28, 2013 at 2:52 AM, Dag-Erling Smørgrav <des at freebsd.org> wrote:
> > Author: des
> > Date: Tue May 28 09:52:28 2013
> > New Revision: 251058
> > URL: http://svnweb.freebsd.org/changeset/base/251058
> >
> > Log:
> >   During buildkernel, print a banner before building modules.
> >
> > Modified:
> >   head/Makefile.inc1
> >
> > Modified: head/Makefile.inc1
> > ==============================================================================
> > --- head/Makefile.inc1  Tue May 28 09:51:27 2013        (r251057)
> > +++ head/Makefile.inc1  Tue May 28 09:52:28 2013        (r251058)
> > @@ -983,9 +983,16 @@ buildkernel:
> >  .endif
> >         @echo
> >         @echo "--------------------------------------------------------------"
> > -       @echo ">>> stage 3.2: building everything"
> > +       @echo ">>> stage 3.2: building the kernel"
> >         @echo "--------------------------------------------------------------"
> > -       cd ${KRNLOBJDIR}/${_kernel}; ${KMAKE} all -DNO_MODULES_OBJ
> > +       cd ${KRNLOBJDIR}/${_kernel}; ${KMAKE} kernel-all -DNO_MODULES_OBJ
> > +       @echo
> > +.if !defined(MODULES_WITH_WORLD) && !defined(NO_MODULES) && exists(${KERNSRCDIR}/modules)
> > +       @echo "--------------------------------------------------------------"
> > +       @echo ">>> stage 3.3: building the modules"
> > +       @echo "--------------------------------------------------------------"
> > +       cd ${KRNLOBJDIR}/${_kernel}; ${KMAKE} modules-all -DNO_MODULES_OBJ
> > +.endif
> >         @echo "--------------------------------------------------------------"
> >         @echo ">>> Kernel build for ${_kernel} completed on `LC_ALL=C date`"
> >         @echo "--------------------------------------------------------------"
> 
> Please back this out or fix it ASAP. You broke every single machine in
> the freebsd.org cluster.
> 
> make: don't know how to make modules-all. Stop
> *** [buildkernel] Error code 2
> 
> You are causing it to stop respecting makeoptions in the kernel config
> files.  eg:
> 
> eg:
> 
> makeoptions     NO_MODULES=no
> or
> makeoptions MODULES_OVERRIDE="zfs opensolaris"
> 
> If you really want this echo here then you're going to need to reach
> down into the internals and make 'modules-all' work even when
> NO_MODULES is set.

This also breaks i386 PAE build in tinderbox...

make: don't know how to make modules-all. Stop

make: stopped in /obj/i386.i386/src/sys/PAE
*** Error code 2

Stop.
make: stopped in /src
*** Error code 1

Stop in /src.
TB --- 2013-05-28 21:10:00 - WARNING: /usr/bin/make returned exit code
1
TB --- 2013-05-28 21:10:00 - ERROR: failed to build PAE kernel
TB --- 2013-05-28 21:10:00 - 18049.16 user 3184.18 system 22779.88 real


http://tinderbox.freebsd.org/tinderbox-head-build-HEAD-i386-i386.full

Glen

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-src-all/attachments/20130528/0484100c/attachment.sig>