svn commit: r251058 - head

[Peter Wemm]

On Tue, May 28, 2013 at 2:52 AM, Dag-Erling Smørgrav <des at freebsd.org> wrote:
> Author: des
> Date: Tue May 28 09:52:28 2013
> New Revision: 251058
> URL: http://svnweb.freebsd.org/changeset/base/251058
>
> Log:
>   During buildkernel, print a banner before building modules.
>
> Modified:
>   head/Makefile.inc1
>
> Modified: head/Makefile.inc1
> ==============================================================================
> --- head/Makefile.inc1  Tue May 28 09:51:27 2013        (r251057)
> +++ head/Makefile.inc1  Tue May 28 09:52:28 2013        (r251058)
> @@ -983,9 +983,16 @@ buildkernel:
>  .endif
>         @echo
>         @echo "--------------------------------------------------------------"
> -       @echo ">>> stage 3.2: building everything"
> +       @echo ">>> stage 3.2: building the kernel"
>         @echo "--------------------------------------------------------------"
> -       cd ${KRNLOBJDIR}/${_kernel}; ${KMAKE} all -DNO_MODULES_OBJ
> +       cd ${KRNLOBJDIR}/${_kernel}; ${KMAKE} kernel-all -DNO_MODULES_OBJ
> +       @echo
> +.if !defined(MODULES_WITH_WORLD) && !defined(NO_MODULES) && exists(${KERNSRCDIR}/modules)
> +       @echo "--------------------------------------------------------------"
> +       @echo ">>> stage 3.3: building the modules"
> +       @echo "--------------------------------------------------------------"
> +       cd ${KRNLOBJDIR}/${_kernel}; ${KMAKE} modules-all -DNO_MODULES_OBJ
> +.endif
>         @echo "--------------------------------------------------------------"
>         @echo ">>> Kernel build for ${_kernel} completed on `LC_ALL=C date`"
>         @echo "--------------------------------------------------------------"

Please back this out or fix it ASAP. You broke every single machine in
the freebsd.org cluster.

make: don't know how to make modules-all. Stop
*** [buildkernel] Error code 2

You are causing it to stop respecting makeoptions in the kernel config
files.  eg:

eg:

makeoptions     NO_MODULES=no
or
makeoptions MODULES_OVERRIDE="zfs opensolaris"

If you really want this echo here then you're going to need to reach
down into the internals and make 'modules-all' work even when
NO_MODULES is set.
-- 
Peter Wemm - peter at wemm.org; peter at FreeBSD.org; peter at yahoo-inc.com; KI6FJV