svn commit: r259642 - head/sys/netinet

Adrian Chadd adrian at freebsd.org
Fri Dec 20 17:05:43 UTC 2013


On 20 December 2013 00:44, Gleb Smirnoff <glebius at freebsd.org> wrote:

> I didn't get to review of actual patch, but IMO it would be better
> just to remove the code, not ifdef 0 it. The code ifdefed has zero
> probability to be enabled in its current form. If we ever fix it, code
> would look very different.
>
> No reason to do followup commit, that was just me muttering.

I figured it would be nicer in the short term to #if 0 it out whilst
some other discussions went on, just to make it really obvious in the
short term where the check was done. It's quite possible I'll
eventually just trim it entirely out.

Thanks,


-a


More information about the svn-src-all mailing list