svn commit: r196435 - head/sys/conf
dougb at FreeBSD.org
Sun Aug 23 06:09:40 UTC 2009
Juli Mallett wrote:
> On Sat, Aug 22, 2009 at 22:45, Doug Barton<dougb at freebsd.org> wrote:
>> Author: dougb
>> Date: Sun Aug 23 05:45:38 2009
>> New Revision: 196435
>> URL: http://svn.freebsd.org/changeset/base/196435
>> The svnversion string is only relevant when newvers.sh is called
>> during the kernel build process, the other places that call the script
>> do not make use of that information. So restrict execution of the
>> svnversion-related code to the kernel build context.
> This seems to assume that the kernel is always checked out in a
> directory called 'sys',
Yes, I think that's a reasonable assumption.
> Is it harmful to include the svnversion stuff for other newvers.sh
There was whinging that it took a "long time" to run svnversion on the
whole src tree, so a very badly formed patch was applied to try and
conditionalize it for only running when the kernel is being built.
This change will actually restrict it to when the kernel is being
built in a directory called */sys/* which will actually work for the
vast majority of FreeBSD users.
> Could they just set an environment variable to indicate they
> want it excluded? Or could you check the environment for kernel
> build-related variables? Or even set a variable when running
> newvers.sh for the kernel to explicitly request svnversion inclusion?
Knock yourself out, I look forward to reviewing your patches.
This very simple little item has already received WAY more hackery
than it really merits. The only reason I made the change I did (after
swearing off touching it again on the principle of trying to avoid
getting bike shed paint all over my clothes) was that the patch that
was applied previously was just plain silly.
FWIW, your comments would have been a lot more timely if they had been
in response to my posting this patch following the discussion on the
topic in -current on 8/15. Given that I have received no comments on
that post at all in the 7 days since posting the patch I felt it was
more than reasonable to commit it tonight.
This .signature sanitized for your protection
More information about the svn-src-all