svn commit: r196435 - head/sys/conf
jmallett at FreeBSD.org
Sun Aug 23 05:53:21 UTC 2009
On Sat, Aug 22, 2009 at 22:45, Doug Barton<dougb at freebsd.org> wrote:
> Author: dougb
> Date: Sun Aug 23 05:45:38 2009
> New Revision: 196435
> URL: http://svn.freebsd.org/changeset/base/196435
> The svnversion string is only relevant when newvers.sh is called
> during the kernel build process, the other places that call the script
> do not make use of that information. So restrict execution of the
> svnversion-related code to the kernel build context.
This seems to assume that the kernel is always checked out in a
directory called 'sys', is that right? That isn't always true in my
experience, and I have a bad habit of keeping multiple kernel trees
checked out named things like 'sys-head', etc. I could be misreading
the code, which gave only constructs I'm not very familiar with for
determining whether it's being used for a kernel build.
Is it harmful to include the svnversion stuff for other newvers.sh
users? Could they just set an environment variable to indicate they
want it excluded? Or could you check the environment for kernel
build-related variables? Or even set a variable when running
newvers.sh for the kernel to explicitly request svnversion inclusion?
More information about the svn-src-all