svn commit: r568508 - head/devel/node-gyp

[Juraj Lutter]

> On 16 Mar 2021, at 22:17, Mathieu Arnold <mat at FreeBSD.org> wrote:
> 
> On Mon, Mar 15, 2021 at 09:02:55PM +0000, Juraj Lutter wrote:
>> Author: otis
>> Date: Mon Mar 15 21:02:55 2021
>> New Revision: 568508
>> URL: https://svnweb.freebsd.org/changeset/ports/568508
>> 
>> Log:
>>  Add port: devel/node-gyp: a build frmework for building Node.js applications.
> 
> A few problems with this, and the next 2 ports added, so putting my
> portmgr's hat on.
> 
> We do not add node modules to the ports tree.
> We really do not add node modules to the ports tree.
> 
> If an application needs nodes modules to work, then the port for that
> application needs to handle the modules installing, and put those in a
> private place.
> 
> lib/node_modules is a really aweful place to put this.  As a side note,
> if we were to add node modules to the ports tree, which we are not, it
> would probably be libdata/node_modules or share/node_modules.
> 
> Please remove those ports.


The rationale behind this is:
- Upcoming textproc/kibana7 has “re2” node module bundled, which also contains
a re2.node binary module, that (from distribution tarball) can be for Linux or Darwin.

- In order to build re2.node binary component for FreeBSD in poudriere without need for
network access that would otherwise be needed, separate port seemed the most ellegant way.

I value your comment and any hints/advises are welcome.

Thanks
otis

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: Message signed with OpenPGP
URL: <http://lists.freebsd.org/pipermail/svn-ports-head/attachments/20210316/80d75d6b/attachment.sig>