svn commit: r568508 - head/devel/node-gyp

Mathieu Arnold mat at freebsd.org
Tue Mar 16 21:17:21 UTC 2021


On Mon, Mar 15, 2021 at 09:02:55PM +0000, Juraj Lutter wrote:
> Author: otis
> Date: Mon Mar 15 21:02:55 2021
> New Revision: 568508
> URL: https://svnweb.freebsd.org/changeset/ports/568508
> 
> Log:
>   Add port: devel/node-gyp: a build frmework for building Node.js applications.

A few problems with this, and the next 2 ports added, so putting my
portmgr's hat on.

We do not add node modules to the ports tree.
We really do not add node modules to the ports tree.

If an application needs nodes modules to work, then the port for that
application needs to handle the modules installing, and put those in a
private place.

lib/node_modules is a really aweful place to put this.  As a side note,
if we were to add node modules to the ports tree, which we are not, it
would probably be libdata/node_modules or share/node_modules.

Please remove those ports.

>   Reviewed by:	osa (mentor)
>   Approved by:	osa (mentor)
>   Differential Revision:	https://reviews.freebsd.org/D29263
> 
> Added:
>   head/devel/node-gyp/
>   head/devel/node-gyp/Makefile   (contents, props changed)
>   head/devel/node-gyp/distinfo   (contents, props changed)
>   head/devel/node-gyp/pkg-descr   (contents, props changed)
>   head/devel/node-gyp/pkg-plist   (contents, props changed)
> 
> Added: head/devel/node-gyp/Makefile
> ==============================================================================
> --- /dev/null	00:00:00 1970	(empty, because file is newly added)
> +++ head/devel/node-gyp/Makefile	Mon Mar 15 21:02:55 2021	(r568508)
> @@ -0,0 +1,31 @@
> +# $FreeBSD$
> +
> +PORTNAME=	gyp
> +DISTVERSIONPREFIX=	v
> +DISTVERSION=	7.1.2
> +CATEGORIES=	devel
> +PKGNAMEPREFIX=	node-
> +
> +MAINTAINER=	otis at FreeBSD.org
> +COMMENT=	Cross-platform command-line tool written in Node.js
> +
> +LICENSE=	MIT
> +
> +BUILD_DEPENDS=	${LOCALBASE}/bin/npm:www/npm
> +
> +USE_GITHUB=	yes
> +GH_ACCOUNT=	nodejs
> +GH_PROJECT=	node-gyp
> +
> +NO_ARCH=	yes
> +NO_BUILD=	yes
> +
> +do-install:
> +	${MKDIR} ${STAGEDIR}${PREFIX}/lib/node_modules/node-gyp
> +	(cd ${WRKSRC} && \
> +	${COPYTREE_SHARE} . ${STAGEDIR}${PREFIX}/lib/node_modules/node-gyp \
> +	"! ( -name \.* -or -path *\/\.github\/* -or -name test -or -path *\/test\/* )")
> +	${RLN} ${STAGEDIR}${PREFIX}/lib/node_modules/node-gyp/bin/node-gyp.js \
> +		${STAGEDIR}${PREFIX}/bin/node-gyp
> +
> +.include <bsd.port.mk>
> 
> Added: head/devel/node-gyp/distinfo
> ==============================================================================
> --- /dev/null	00:00:00 1970	(empty, because file is newly added)
> +++ head/devel/node-gyp/distinfo	Mon Mar 15 21:02:55 2021	(r568508)
> @@ -0,0 +1,3 @@
> +TIMESTAMP = 1615743601
> +SHA256 (nodejs-node-gyp-v7.1.2_GH0.tar.gz) = e9a42f7afa3e5386c1dee094b8751f6924e75d6921166d1cad6ebafc19c54957
> +SIZE (nodejs-node-gyp-v7.1.2_GH0.tar.gz) = 439880
> 
> Added: head/devel/node-gyp/pkg-descr
> ==============================================================================
> --- /dev/null	00:00:00 1970	(empty, because file is newly added)
> +++ head/devel/node-gyp/pkg-descr	Mon Mar 15 21:02:55 2021	(r568508)
> @@ -0,0 +1,6 @@
> +node-gyp is a cross-platform command-line tool written in Node.js for
> +compiling native addon modules for Node.js. It contains a vendored copy
> +of the gyp-next project that was previously used by the Chromium team,
> +extended to support the development of Node.js native addons.
> +
> +WWW: https://github.com/nodejs/node-gyp
> 
> Added: head/devel/node-gyp/pkg-plist
> ==============================================================================
> --- /dev/null	00:00:00 1970	(empty, because file is newly added)
> +++ head/devel/node-gyp/pkg-plist	Mon Mar 15 21:02:55 2021	(r568508)
> @@ -0,0 +1,95 @@
> +bin/node-gyp
> +lib/node_modules/node-gyp/CHANGELOG.md
> +lib/node_modules/node-gyp/CONTRIBUTING.md
> +lib/node_modules/node-gyp/LICENSE
> +lib/node_modules/node-gyp/README.md
> +lib/node_modules/node-gyp/addon.gypi
> +@(,,755) lib/node_modules/node-gyp/bin/node-gyp.js
> +lib/node_modules/node-gyp/gyp/AUTHORS
> +lib/node_modules/node-gyp/gyp/CHANGELOG.md
> +lib/node_modules/node-gyp/gyp/CODE_OF_CONDUCT.md
> +lib/node_modules/node-gyp/gyp/CONTRIBUTING.md
> +lib/node_modules/node-gyp/gyp/LICENSE
> +lib/node_modules/node-gyp/gyp/README.md
> +lib/node_modules/node-gyp/gyp/data/win/large-pdb-shim.cc
> +lib/node_modules/node-gyp/gyp/gyp
> +lib/node_modules/node-gyp/gyp/gyp.bat
> +lib/node_modules/node-gyp/gyp/gyp_main.py
> +lib/node_modules/node-gyp/gyp/pylib/gyp/MSVSNew.py
> +lib/node_modules/node-gyp/gyp/pylib/gyp/MSVSProject.py
> +lib/node_modules/node-gyp/gyp/pylib/gyp/MSVSSettings.py
> +lib/node_modules/node-gyp/gyp/pylib/gyp/MSVSSettings_test.py
> +lib/node_modules/node-gyp/gyp/pylib/gyp/MSVSToolFile.py
> +lib/node_modules/node-gyp/gyp/pylib/gyp/MSVSUserFile.py
> +lib/node_modules/node-gyp/gyp/pylib/gyp/MSVSUtil.py
> +lib/node_modules/node-gyp/gyp/pylib/gyp/MSVSVersion.py
> +lib/node_modules/node-gyp/gyp/pylib/gyp/__init__.py
> +lib/node_modules/node-gyp/gyp/pylib/gyp/common.py
> +lib/node_modules/node-gyp/gyp/pylib/gyp/common_test.py
> +lib/node_modules/node-gyp/gyp/pylib/gyp/easy_xml.py
> +lib/node_modules/node-gyp/gyp/pylib/gyp/easy_xml_test.py
> +lib/node_modules/node-gyp/gyp/pylib/gyp/flock_tool.py
> +lib/node_modules/node-gyp/gyp/pylib/gyp/generator/__init__.py
> +lib/node_modules/node-gyp/gyp/pylib/gyp/generator/analyzer.py
> +lib/node_modules/node-gyp/gyp/pylib/gyp/generator/android.py
> +lib/node_modules/node-gyp/gyp/pylib/gyp/generator/cmake.py
> +lib/node_modules/node-gyp/gyp/pylib/gyp/generator/compile_commands_json.py
> +lib/node_modules/node-gyp/gyp/pylib/gyp/generator/dump_dependency_json.py
> +lib/node_modules/node-gyp/gyp/pylib/gyp/generator/eclipse.py
> +lib/node_modules/node-gyp/gyp/pylib/gyp/generator/gypd.py
> +lib/node_modules/node-gyp/gyp/pylib/gyp/generator/gypsh.py
> +lib/node_modules/node-gyp/gyp/pylib/gyp/generator/make.py
> +lib/node_modules/node-gyp/gyp/pylib/gyp/generator/msvs.py
> +lib/node_modules/node-gyp/gyp/pylib/gyp/generator/msvs_test.py
> +lib/node_modules/node-gyp/gyp/pylib/gyp/generator/ninja.py
> +lib/node_modules/node-gyp/gyp/pylib/gyp/generator/ninja_test.py
> +lib/node_modules/node-gyp/gyp/pylib/gyp/generator/xcode.py
> +lib/node_modules/node-gyp/gyp/pylib/gyp/generator/xcode_test.py
> +lib/node_modules/node-gyp/gyp/pylib/gyp/input.py
> +lib/node_modules/node-gyp/gyp/pylib/gyp/input_test.py
> +lib/node_modules/node-gyp/gyp/pylib/gyp/mac_tool.py
> +lib/node_modules/node-gyp/gyp/pylib/gyp/msvs_emulation.py
> +lib/node_modules/node-gyp/gyp/pylib/gyp/ninja_syntax.py
> +lib/node_modules/node-gyp/gyp/pylib/gyp/simple_copy.py
> +lib/node_modules/node-gyp/gyp/pylib/gyp/win_tool.py
> +lib/node_modules/node-gyp/gyp/pylib/gyp/xcode_emulation.py
> +lib/node_modules/node-gyp/gyp/pylib/gyp/xcode_ninja.py
> +lib/node_modules/node-gyp/gyp/pylib/gyp/xcodeproj_file.py
> +lib/node_modules/node-gyp/gyp/pylib/gyp/xml_fix.py
> +lib/node_modules/node-gyp/gyp/requirements_dev.txt
> +lib/node_modules/node-gyp/gyp/setup.py
> +lib/node_modules/node-gyp/gyp/test_gyp.py
> +lib/node_modules/node-gyp/gyp/tools/README
> +lib/node_modules/node-gyp/gyp/tools/Xcode/README
> +lib/node_modules/node-gyp/gyp/tools/Xcode/Specifications/gyp.pbfilespec
> +lib/node_modules/node-gyp/gyp/tools/Xcode/Specifications/gyp.xclangspec
> +lib/node_modules/node-gyp/gyp/tools/emacs/README
> +lib/node_modules/node-gyp/gyp/tools/emacs/gyp-tests.el
> +lib/node_modules/node-gyp/gyp/tools/emacs/gyp.el
> +lib/node_modules/node-gyp/gyp/tools/emacs/run-unit-tests.sh
> +lib/node_modules/node-gyp/gyp/tools/emacs/testdata/media.gyp
> +lib/node_modules/node-gyp/gyp/tools/emacs/testdata/media.gyp.fontified
> +lib/node_modules/node-gyp/gyp/tools/graphviz.py
> +lib/node_modules/node-gyp/gyp/tools/pretty_gyp.py
> +lib/node_modules/node-gyp/gyp/tools/pretty_sln.py
> +lib/node_modules/node-gyp/gyp/tools/pretty_vcproj.py
> +lib/node_modules/node-gyp/lib/Find-VisualStudio.cs
> +lib/node_modules/node-gyp/lib/build.js
> +lib/node_modules/node-gyp/lib/clean.js
> +lib/node_modules/node-gyp/lib/configure.js
> +lib/node_modules/node-gyp/lib/find-node-directory.js
> +lib/node_modules/node-gyp/lib/find-python.js
> +lib/node_modules/node-gyp/lib/find-visualstudio.js
> +lib/node_modules/node-gyp/lib/install.js
> +lib/node_modules/node-gyp/lib/list.js
> +lib/node_modules/node-gyp/lib/node-gyp.js
> +lib/node_modules/node-gyp/lib/process-release.js
> +lib/node_modules/node-gyp/lib/proxy.js
> +lib/node_modules/node-gyp/lib/rebuild.js
> +lib/node_modules/node-gyp/lib/remove.js
> +lib/node_modules/node-gyp/lib/util.js
> +lib/node_modules/node-gyp/macOS_Catalina.md
> +lib/node_modules/node-gyp/macOS_Catalina_acid_test.sh
> +lib/node_modules/node-gyp/package.json
> +lib/node_modules/node-gyp/src/win_delay_load_hook.cc
> +lib/node_modules/node-gyp/update-gyp.py
> 

-- 
Mathieu Arnold
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 963 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-head/attachments/20210316/99dcd903/attachment.sig>


More information about the svn-ports-head mailing list