svn commit: r468086 - in head/math: . piranha

[Mathieu Arnold]

On Mon, Apr 23, 2018 at 08:44:15AM -0700, Yuri wrote:
> On 04/23/18 05:37, Mathieu Arnold wrote:
> > Unless this really needs cmake and ninja to run, please reverse the way
> > you create the BUILD_DEPENDS and RUN_DEPENDS variables.  You may have
> > noticed many ports do BUILD_DEPENDS=${RUN_DEPENDS} and RUN_DEPENDS=blah.
> 
> 
> The way how they defined the build, it does involve cmake. cmake isn't
> "really needed" because cmake doesn't really build anything, but it does
> install it. It is also needed for the 'test' target.
> 
> You prefer it the way around, "BUILD_DEPENDS=${RUN_DEPENDS} and
> RUN_DEPENDS=blah"?

I do not prefer it, I ask for you to change it because what you did is
not correct.

> But doesn't it end up being the same?

No it does not.  See other reply.

-- 
Mathieu Arnold
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 949 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-head/attachments/20180423/e606d53f/attachment.sig>