svn commit: r468086 - in head/math: . piranha

[Joseph Mingrone]

Yuri <yuri at freebsd.org> writes:

> On 04/23/18 05:37, Mathieu Arnold wrote:
>> Unless this really needs cmake and ninja to run, please reverse the way
>> you create the BUILD_DEPENDS and RUN_DEPENDS variables.  You may have
>> noticed many ports do BUILD_DEPENDS=${RUN_DEPENDS} and RUN_DEPENDS=blah.


> The way how they defined the build, it does involve cmake. cmake isn't "really needed" because cmake doesn't really build anything, but it does install it. It is also needed for the 'test' target.

> You prefer it the way around, "BUILD_DEPENDS=${RUN_DEPENDS} and RUN_DEPENDS=blah"? But doesn't it end up being the same?


> Yuri


Hello Yuri,

USES=cmake:outsource adds to BUILD_DEPENDS, so when you set RUN_DEPENDS
to BUILD_DEPENDS, you add unwanted ports to RUN_DEPENDS.

Current port:
% make -VRUN_DEPENDS
/usr/local/include/boost/numeric/conversion/cast.hpp:devel/boost-libs
/usr/local/include/gmp.h:math/gmp  /usr/local/include/mpfr.h:math/mpfr
/usr/local/bin/cmake:devel/cmake ninja:devel/ninja

With:
BUILD_DEPENDS=  ${RUN_DEPENDS}
RUN_DEPENDS=    ${LOCALBASE}/include/boost/numeric/conversion/cast.hpp:devel/boost-libs \
                ${LOCALBASE}/include/gmp.h:math/gmp \
                ${LOCALBASE}/include/mpfr.h:math/mpfr

% make -VRUN_DEPENDS
/usr/local/include/boost/numeric/conversion/cast.hpp:devel/boost-libs
/usr/local/include/gmp.h:math/gmp  /usr/local/include/mpfr.h:math/mpfr

J.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 962 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-head/attachments/20180423/f736f735/attachment.sig>