svn commit: r457244 - in head/multimedia/mpv: . files

[Alexey Dokuchaev]

On Tue, Dec 26, 2017 at 01:02:50PM +0100, Carlos J. Puga Medina wrote:
> On Tue, 2017-12-26 at 11:06 +0000, Alexey Dokuchaev wrote:
> > On Mon, Dec 25, 2017 at 06:00:52PM +0000, Carlos J. Puga Medina
> > wrote:
> > > New Revision: 457244
> > > URL: https://svnweb.freebsd.org/changeset/ports/457244
> > > 
> > > Log:
> > >   multimedia/mpv: Add VAAPI on Wayland support
> > >   
> > >   - Add support to enable VAAPI under Wayland (disabled by default)
> > >   - Regenerate patch with makepatch to make portlint happy
> > >   
> > > +.include <bsd.port.options.mk>
> > > +
> > > +.if ${PORT_OPTIONS:MVAAPI} && ${PORT_OPTIONS:MWAYLAND}
> > > +CONFIGURE_ARGS+=	--enable-vaapi-wayland
> > > +LIB_DEPENDS+=		libva-wayland.so:multimedia/libva
> > > +.else
> > > +CONFIGURE_ARGS+=	--disable-vaapi-wayland
> > > +.endif
> > 
> > Consider using option helpers (shorter, more readable, declarative
> > style,
> > no .include <bsd.port.options.mk> needed):
> > 
> > VAAPI_IMPLIES=	WAYLAND
> > 
> > VAAPI_LIB_DEPENDS=	libva-wayland.so:multimedia/libva
> > VAAPI_CONFIGURE_ENABLE=	vaapi-wayland
> 
> If I switch to option helpers then VAAPI option should be disabled
> because it pulls some libraries not available.

Ah, OK, so VAAPI does not actually imply WAYLAND.  Sorry for the noise.

./danfe