svn commit: r457244 - in head/multimedia/mpv: . files

[Carlos J. Puga Medina]

On Tue, 2017-12-26 at 11:06 +0000, Alexey Dokuchaev wrote:
> On Mon, Dec 25, 2017 at 06:00:52PM +0000, Carlos J. Puga Medina
> wrote:
> > New Revision: 457244
> > URL: https://svnweb.freebsd.org/changeset/ports/457244
> > 
> > Log:
> >   multimedia/mpv: Add VAAPI on Wayland support
> >   
> >   - Add support to enable VAAPI under Wayland (disabled by default)
> >   - Regenerate patch with makepatch to make portlint happy
> >   
> > +.include <bsd.port.options.mk>
> > +
> > +.if ${PORT_OPTIONS:MVAAPI} && ${PORT_OPTIONS:MWAYLAND}
> > +CONFIGURE_ARGS+=	--enable-vaapi-wayland
> > +LIB_DEPENDS+=		libva-wayland.so:multimedia/libva
> > +.else
> > +CONFIGURE_ARGS+=	--disable-vaapi-wayland
> > +.endif
> 
> Consider using option helpers (shorter, more readable, declarative
> style,
> no .include <bsd.port.options.mk> needed):
> 
> VAAPI_IMPLIES=	WAYLAND
> 
> VAAPI_LIB_DEPENDS=	libva-wayland.so:multimedia/libva
> VAAPI_CONFIGURE_ENABLE=	vaapi-wayland
> 

If I switch to option helpers then VAAPI option should be disabled
because it pulls some libraries not available. WAYLAND support is not
enable by default.

% find /usr/ports -name Makefile | xargs grep WAYLAND
/usr/ports/graphics/mesa-libs/Makefile:OPTIONS_DEFINE=	WAYLAND
/usr/ports/graphics/mesa-libs/Makefile:WAYLAND_DESC=		Ena
ble support for the Wayland platform in EGL
/usr/ports/graphics/mesa-libs/Makefile:WAYLAND_BUILD_DEPENDS=	wa
yland-protocols>=1.8:graphics/wayland-protocols
/usr/ports/graphics/mesa-libs/Makefile:WAYLAND_LIB_DEPENDS=	libw
ayland-client.so:graphics/wayland \
/usr/ports/graphics/mesa-libs/Makefile:.if ${PORT_OPTIONS:MWAYLAND}
/usr/ports/graphics/mesa-libs/Makefile:.if ${PORT_OPTIONS:MWAYLAND}
/usr/ports/graphics/mesa-libs/Makefile:IGNORE=	option WAYLAND is
only valid on platforms with LLVM
/usr/ports/graphics/mesa-libs/Makefile:.if ${PORT_OPTIONS:MWAYLAND}
/usr/ports/multimedia/mpv/Makefile:OPTIONS_GROUP_VO=	CACA OPENGL
VAAPI VDPAU WAYLAND X11
/usr/ports/multimedia/mpv/Makefile:WAYLAND_DESC=		Wayland
(graphics) support
/usr/ports/multimedia/mpv/Makefile:WAYLAND_LIB_DEPENDS=		
libwayland-client.so:graphics/wayland \
/usr/ports/multimedia/mpv/Makefile:WAYLAND_CONFIGURE_OFF=		
--disable-wayland
/usr/ports/multimedia/mpv/Makefile:.if ${PORT_OPTIONS:MVAAPI} &&
${PORT_OPTIONS:MWAYLAND}
/usr/ports/multimedia/libva/Makefile:OPTIONS_DEFINE=	DEBUG
WAYLAND
/usr/ports/multimedia/libva/Makefile:WAYLAND_DESC=	Support
wayland protocol
/usr/ports/multimedia/libva/Makefile:WAYLAND_CONFIGURE_ENABLE=	w
ayland
/usr/ports/multimedia/libva/Makefile:WAYLAND_LIB_DEPENDS=	libway
land-client.so:graphics/wayland
/usr/ports/multimedia/libva/Makefile:WAYLAND_BUILD_DEPENDS=	gsed
:textproc/gsed
/usr/ports/multimedia/libva/Makefile:post-configure-WAYLAND-on: .SILENT
/usr/ports/net/freerdp1/Makefile:CMAKE_ARGS+=	-DWITH_LIBSYSTEMD=
OFF -DWITH_WAYLAND=OFF -DWITH_GSTREAMER_0_10=OFF ${CMAKE_ARGS_${ARCH}}
/usr/ports/net/freerdp/Makefile:CMAKE_ARGS+=	-DWITH_LIBSYSTEMD=O
FF -DWITH_WAYLAND=OFF -DWITH_GSTREAMER_0_10=OFF ${CMAKE_ARGS_${ARCH}}
/usr/ports/www/webkit2-gtk3/Makefile:		-DENABLE_WAYLAND_T
ARGET:BOOL=OFF \

Cheers,
-- 
Carlos Jacobo Puga Medina <cpm at FreeBSD.org>
PGP fingerprint = C60E 9497 5302 793B CC2D  BB89 A1F3 5D66 E6D0 5453
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 618 bytes
Desc: This is a digitally signed message part
URL: <http://lists.freebsd.org/pipermail/svn-ports-head/attachments/20171226/99fe6611/attachment.sig>