svn commit: r456124 - head/Mk/Uses

[Ben Woods]

On Wed, 13 Dec 2017 at 1:31 am, Mathieu Arnold <mat at freebsd.org> wrote:

> Author: mat
> Date: Tue Dec 12 12:31:10 2017
> New Revision: 456124
> URL: https://svnweb.freebsd.org/changeset/ports/456124
>
> Log:
>   Add a DEV_WARNING about some hypotetical case.
>
>   Sponsored by: Absolight
>
> Modified:
>   head/Mk/Uses/python.mk
>
> Modified: head/Mk/Uses/python.mk
>
> ==============================================================================
> --- head/Mk/Uses/python.mk      Tue Dec 12 12:16:37 2017        (r456123)
> +++ head/Mk/Uses/python.mk      Tue Dec 12 12:31:10 2017        (r456124)
> @@ -566,6 +566,9 @@ RUN_DEPENDS+=       cython-${PYTHON_VER}:lang/cython@
> ${PY_FL
>  .endif
>
>  .if defined(_PYTHON_FEATURE_CONCURRENT)
> +.if !defined(_PYTHON_FEATURE_FLAVORS) && (${_PYTHON_VERSION_MINIMUM:M3*}
> || ${_PYTHON_VERSION_MAXIMUM:M2*})
> +DEV_WARNING+=  "USE_PYTHON=concurrent when only one of Python 2 or 3 is
> supported AND not using flavors does not make any sense"
> +.endif
>  _USES_POST+=           uniquefiles:dirs
>  .if defined(_PYTHON_FEATURE_FLAVORS) && ${FLAVOR} == ${FLAVORS:[1]}
>  UNIQUE_DEFAULT_LINKS=  yes



Hi Mat,

I’m not sure I fully understand this warning, so perhaps it needs a few
more words about “why”?

Even with flavors, it is still likely people will want 2 flavors of a port
concurrently installed.

Does adding flavors already handle concurrent installation, making the
concurrent keyword unnecessary with flavors enabled?

Thanks in advance.

Regards,
Ben

> --

--
From: Benjamin Woods
woodsb02 at gmail.com