svn commit: r366841 - head/lang/tcl86/files

[Adam Weinberger]

On 1 Sep, 2014, at 3:46, Alexey Dokuchaev <danfe at FreeBSD.org> wrote:

> On Mon, Sep 01, 2014 at 07:31:53AM +0000, Pietro Cerutti wrote:
>> New Revision: 366841
>> URL: http://svnweb.freebsd.org/changeset/ports/366841
>> QAT: https://qat.redports.org/buildarchive/r366841/
>> 
>> Log:
>>  - Fix customization of Tcl modules path
>> 
>> Modified:
>>  head/lang/tcl86/files/patch-unix-Makefile.in
>> 
>> Modified: head/lang/tcl86/files/patch-unix-Makefile.in
>> ==============================================================================
>> --- head/lang/tcl86/files/patch-unix-Makefile.in	Mon Sep  1 07:26:14 2014	(r366840)
>> +++ head/lang/tcl86/files/patch-unix-Makefile.in	Mon Sep  1 07:31:53 2014	(r366841)
>> @@ -1,5 +1,5 @@
>> ---- Makefile.in.orig	2014-08-26 15:23:08 UTC
>> -+++ Makefile.in
>> +--- Makefile.in.orig	2014-08-26 17:23:08.000000000 +0200
>> ++++ Makefile.in	2014-09-01 09:32:00.000000000 +0200
> 
> Now isn't it nice: someone corrected the patch header for you, making it
> TZ-agnostic, nice looking without that stupid zer000000000s so subsequent
> commits will have deduced churn.  And you've just reverted it back to the
> middle ages.
> 
> Since when did we abandon the practice of doing 'svn diff' before commit?

Alexey, please direct your frustration elsewhere. Pietro fixed (hopefully) a problem that caused a lot of tcl-dependent ports to break. He should be commended, not sneered at. If you don’t like the way makepatch works, take it up with portmgr, not with the committers who use it. I know for a fact that portmgr is interested in extending makepatch to DTRT.

Besides, there are simply situations where makepatch is just not the tool to use. Sometimes I *have* to run diff(1) by hand. Sometimes I need to run "make patch” before I can edit the diff. Sometimes I’ve edited multiple files and I want to test one diff at a time. Sometimes a file needs to be touched by two different patches (I don’t like it, but ten years ago it seems like people really did).

If you REALLY want to solve that issue, make a change to src/gnu/usr.bin/diff so that it will take a flag to not put timestamps in there.

Past that, please stop venting at committers about this. I just checked and I couldn’t find any time correlation between the Malaysian Air flights going down and people committing timestamps in patches.

# Adam


-- 
Adam Weinberger
adamw at adamw.org
http://www.adamw.org