svn commit: r366841 - head/lang/tcl86/files

John Marino freebsd.contact at marino.st
Mon Sep 1 07:51:25 UTC 2014


On 9/1/2014 09:46, Alexey Dokuchaev wrote:
> On Mon, Sep 01, 2014 at 07:31:53AM +0000, Pietro Cerutti wrote:
>> New Revision: 366841
>> URL: http://svnweb.freebsd.org/changeset/ports/366841
>> QAT: https://qat.redports.org/buildarchive/r366841/
>>
>> Log:
>>   - Fix customization of Tcl modules path
>>
>> Modified:
>>   head/lang/tcl86/files/patch-unix-Makefile.in
>>
>> Modified: head/lang/tcl86/files/patch-unix-Makefile.in
>> ==============================================================================
>> --- head/lang/tcl86/files/patch-unix-Makefile.in	Mon Sep  1 07:26:14 2014	(r366840)
>> +++ head/lang/tcl86/files/patch-unix-Makefile.in	Mon Sep  1 07:31:53 2014	(r366841)
>> @@ -1,5 +1,5 @@
>> ---- Makefile.in.orig	2014-08-26 15:23:08 UTC
>> -+++ Makefile.in
>> +--- Makefile.in.orig	2014-08-26 17:23:08.000000000 +0200
>> ++++ Makefile.in	2014-09-01 09:32:00.000000000 +0200
> 
> Now isn't it nice: someone corrected the patch header for you, making it
> TZ-agnostic, nice looking without that stupid zer000000000s so subsequent
> commits will have deduced churn.  And you've just reverted it back to the
> middle ages.
> 
> Since when did we abandon the practice of doing 'svn diff' before commit?


I wouldn't be so hard on him.   The problem is that the makepatch fix
(D582) has been stuck for <fill-in-blank> reasons.  If it had been
available, this wouldn't have happened.

Please push D582 forward, folks  We need it.

John





More information about the svn-ports-head mailing list