svn commit: r485586 - head/java/netty

[Mathieu Arnold]

On Fri, Nov 23, 2018 at 12:48:45PM +0000, Alexey Dokuchaev wrote:
> On Thu, Nov 22, 2018 at 05:19:28PM +0100, Mathieu Arnold wrote:
> > On Thu, Nov 22, 2018 at 03:55:24PM +0300, Dmitry Marakasov wrote:
> > > * Mathieu Arnold (mat at FreeBSD.org) wrote:
> > > > > -PLIST_FILES=	%%JAVAJARDIR%%/netty-${PORTVERSION}.jar \
> > > > > -		%%JAVAJARDIR%%/netty.jar
> > > > > +PLIST_FILES=	${JAVAJARDIR:S,^${PREFIX}/,,}/netty-${PORTVERSION}.jar \
> > > > > +		${JAVAJARDIR:S,^${PREFIX}/,,}/netty.jar
> > > > 
> > > > This seems overly complicated.  What is wrong with having just
> > > > ${JAAAVJARDIR}?
> > > 
> > > It contains absolute path. I've assumed we don't use these in the plist.
> > 
> > Paths in the PLIST are either relative to PREFIX or absolute.  If a path
> > is absolute and starts with PREFIX, it is just fine.
> 
> Absolute paths, however, look ugly in PLIST, and generally do not sound
> like a good idea (e.g., how well do they align with relocatable packages)?

Have a look at the content of a package, all the files in them have full
paths.  Relocation works by doing a s|^/usr/local|/bar|.  

As for the ugly, well, I find ${JAVAJARDIR:S,^${PREFIX}/,,} much worse
than having full path that you will never see because it is hidden
in variables.

-- 
Mathieu Arnold
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 963 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20181123/c30939dd/attachment.sig>