svn commit: r485586 - head/java/netty

Alexey Dokuchaev danfe at freebsd.org
Fri Nov 23 12:48:45 UTC 2018


On Thu, Nov 22, 2018 at 05:19:28PM +0100, Mathieu Arnold wrote:
> On Thu, Nov 22, 2018 at 03:55:24PM +0300, Dmitry Marakasov wrote:
> > * Mathieu Arnold (mat at FreeBSD.org) wrote:
> > > > -PLIST_FILES=	%%JAVAJARDIR%%/netty-${PORTVERSION}.jar \
> > > > -		%%JAVAJARDIR%%/netty.jar
> > > > +PLIST_FILES=	${JAVAJARDIR:S,^${PREFIX}/,,}/netty-${PORTVERSION}.jar \
> > > > +		${JAVAJARDIR:S,^${PREFIX}/,,}/netty.jar
> > > 
> > > This seems overly complicated.  What is wrong with having just
> > > ${JAAAVJARDIR}?
> > 
> > It contains absolute path. I've assumed we don't use these in the plist.
> 
> Paths in the PLIST are either relative to PREFIX or absolute.  If a path
> is absolute and starts with PREFIX, it is just fine.

Absolute paths, however, look ugly in PLIST, and generally do not sound
like a good idea (e.g., how well do they align with relocatable packages)?

./danfe


More information about the svn-ports-all mailing list