svn commit: r484686 - head/net-im/telegram-desktop

[Max Brazhnikov]

On Mon, 12 Nov 2018 at 18:34, Mathieu Arnold <mat at freebsd.org> wrote:
>
> On Sun, Nov 11, 2018 at 11:59:48AM +0000, Max Brazhnikov wrote:
> > On воскресенье, 11 ноября 2018 г. 11:49:16 UTC Jan Beich wrote:
> > > Max Brazhnikov <makc at FreeBSD.org> writes:
> > > > @@ -82,6 +82,7 @@ post-patch:
> > > >           ${FILESDIR}/gyp-patches | \
> > > >           ${PATCH} -z .bak -s)
> > > >
> > > >   @${ECHO} "#define FREEBSD_QT_PLUGINDIR \"${QT_PLUGINDIR}\"" >
> > > >   ${WRKSRC}/Telegram/SourceFiles/FREEBSD_QT_PLUGINDIR.h>
> > > > + ${SED} -i -e "/Icon=/s|telegram|${PORTNAME}|"
> > > > ${WRKSRC}/lib/xdg/telegramdesktop.desktop
> > > Why ${SED} -i instead of ${REINPLACE_CMD}?
> >
> > For sake of consistency with the rest of the file. I leave it to maintainer.
>
> The reason we have committers and not a simple script that commits every
> patch that applies in is so that people who know better (the committers,
> you, Jan, me) fix submissions from maintainers to match our policies and
> way of doing things.
>
> Now, the Makefile is consistenly bad, that is for sure.

Sorry, folks. I promise to take next PR for this port and make it decent :)