svn commit: r484686 - head/net-im/telegram-desktop

[Mathieu Arnold]

On Sun, Nov 11, 2018 at 11:59:48AM +0000, Max Brazhnikov wrote:
> On воскресенье, 11 ноября 2018 г. 11:49:16 UTC Jan Beich wrote:
> > Max Brazhnikov <makc at FreeBSD.org> writes:
> > > @@ -82,6 +82,7 @@ post-patch:
> > >  		${FILESDIR}/gyp-patches | \
> > >  		${PATCH} -z .bak -s)
> > >  	
> > >  	@${ECHO} "#define FREEBSD_QT_PLUGINDIR \"${QT_PLUGINDIR}\"" >
> > >  	${WRKSRC}/Telegram/SourceFiles/FREEBSD_QT_PLUGINDIR.h> 
> > > +	${SED} -i -e "/Icon=/s|telegram|${PORTNAME}|"
> > > ${WRKSRC}/lib/xdg/telegramdesktop.desktop
> > Why ${SED} -i instead of ${REINPLACE_CMD}?
> 
> For sake of consistency with the rest of the file. I leave it to maintainer.

The reason we have committers and not a simple script that commits every
patch that applies in is so that people who know better (the committers,
you, Jan, me) fix submissions from maintainers to match our policies and
way of doing things.

Now, the Makefile is consistenly bad, that is for sure.

-- 
Mathieu Arnold
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 963 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20181112/472d71c3/attachment.sig>