svn commit: r470444 - head/lang/gcc-ecj45
Alexey Dokuchaev
danfe at FreeBSD.org
Mon Jul 16 10:57:53 UTC 2018
On Mon, Jul 16, 2018 at 11:45:30AM +0200, Mathieu Arnold wrote:
> On Sat, Jul 14, 2018 at 10:39:11PM +0200, Gerald Pfeifer wrote:
> > I'm not really sure "cosmetic fixes" are covered by portmgr
> > blanket, especially where something is a style issue.
> >
> > > -EXTRACT_SUFX=
> > > -EXTRACT_ONLY=
> > > +EXTRACT_SUFX= # empty
> > > +EXTRACT_ONLY= # empty
> >
> > ...I preferred the original version of that and do not see this
> > as a real improvement.
>
> There is some kind of, mmmm, style police that, I think, believe
> variables must have a value
No, it's not about that variables must have a value, it's to designate
that it was made empty on purpose, it's not a stray line or some editor
glitch. Kind of like why people write "while (...) continue;" rather
than simply "while (...);". The former clearly shows the intentions,
the latter could be just a stupid bug.
> Never understood it myself.
Hope now it is more clear for you. :-)
./danfe
More information about the svn-ports-all
mailing list