svn commit: r470444 - head/lang/gcc-ecj45

[Mathieu Arnold]

On Sat, Jul 14, 2018 at 10:39:11PM +0200, Gerald Pfeifer wrote:
> On Sun, 20 May 2018, Dmitry Marakasov wrote:
> > Author: amdmi3
> > Date: Sun May 20 09:04:10 2018
> > New Revision: 470444
> > URL: https://svnweb.freebsd.org/changeset/ports/470444
> > 
> > Log:
> >   - Add LICENSE
> >   - Cosmetic fixes
> >   - Add NO_ARCH
> >   
> >   Approved by:	portmgr blanket
> 
> I'm not really sure "cosmetic fixes" are covered by portmgr
> blanket, especially where something is a style issue.
> 
> For example...
> 
> > Modified: head/lang/gcc-ecj45/Makefile
> > ==============================================================================
> > -EXTRACT_SUFX=
> > -EXTRACT_ONLY=
> > +EXTRACT_SUFX=	# empty
> > +EXTRACT_ONLY=	# empty
> 
> ...I preferred the original version of that and do not see this
> as a real improvement.

There is some kind of, mmmm, style police that, I think, believe
variables must have a value, so when a variable is empty, they see it as
their fight to add "# empty" comments everywhere.  Never understood it
myself.

-- 
Mathieu Arnold
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 963 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20180716/b7d048b3/attachment.sig>