svn commit: r446552 - head/devel/dcd-server

[Mathieu Arnold]

Le 26/07/2017 à 12:52, Alexey Dokuchaev a écrit :
> On Wed, Jul 26, 2017 at 12:45:38PM +0200, Mathieu Arnold wrote:
>> Le 26/07/2017 ?? 12:39, Alexey Dokuchaev a ??crit :
>>> On Wed, Jul 26, 2017 at 12:22:45PM +0200, Mathieu Arnold wrote:
>>>> Le 26/07/2017 ?? 09:01, Alexey Dokuchaev a ??crit :
>>>>> On Wed, Jul 26, 2017 at 12:36:01AM +0200, Mathieu Arnold wrote:
>>>>>> Le 25/07/2017 ?? 03:44, Jose Alonso Cardenas Marquez a ??crit :
>>>>>>> New Revision: 446552
>>>>>>> URL: https://svnweb.freebsd.org/changeset/ports/446552
>>>>>>>
>>>>>>> Log:
>>>>>>>   - Add pkg-plist forgotten on previous commit
>>>>>> You need to bump PORTREVISION so that the package is rebuilt with
>>>>>> the plist.
>>>>> Why would it get packaged without (with an empty) plist?
>>>> What are metaports?
>>> "Abstract" ports that don't install things on their own but pull a set of
>>> dependencies?  How's it relevant to `devel/dcd-server', unless I'm missing
>>> something?
>> I guess Jeopardy! is not that a universal thing.
> ENOPARSE, sorry.
>
>> A port without a plist is perfectly valid, it will get build, and
>> packaged just fine. The framework cannot know that you forgot to commit
>> the plist. So if you commit a port and forget the plist, it will get
>> built and the package will have dependencies, and no files. If you then
>> add the plist later, the framework cannot know that the package it built
>> earlier needs to be rebuilt because it has files now, so PORTREVISION
>> needs to be bumped.
> Shouldn't `check-plist' kick in and packaging fail due to untracked files
> being installed and plist forgotten?

It surely does, but reality check:

1) not everybody checks that what they commit actually fetches, builds,
packages, or installs.
2) it does not prevent foot shooting because you forgot to svn add the
pkg-plist file before committing.

-- 
Mathieu Arnold


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 949 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20170726/098df7ad/attachment.sig>