svn commit: r408737 - head/ports-mgmt/portmaster

[Adam Weinberger]

> On 12 Feb, 2016, at 11:01, Jason Helfman <jgh at FreeBSD.org> wrote:
> 
> On Fri, Feb 12, 2016 at 7:46 AM, Mathieu Arnold <mat at freebsd.org> wrote:
>> Author: mat
>> Date: Fri Feb 12 15:46:04 2016
>> New Revision: 408737
>> URL: https://svnweb.freebsd.org/changeset/ports/408737
>> 
>> Log:
>>  Remove unneeded dependencies on bash and zsh.
>> 
>>  With hat:     portmgr
>>  Sponsored by: Absolight
>> 
>> Modified:
>>  head/ports-mgmt/portmaster/Makefile
>> 
>> Modified: head/ports-mgmt/portmaster/Makefile
>> ==============================================================================
>> --- head/ports-mgmt/portmaster/Makefile Fri Feb 12 15:34:10 2016        (r408736)
>> +++ head/ports-mgmt/portmaster/Makefile Fri Feb 12 15:46:04 2016        (r408737)
>> @@ -2,6 +2,7 @@
>> 
>> PORTNAME=      portmaster
>> PORTVERSION=   3.17.9
>> +PORTREVISION=  1
>> CATEGORIES=    ports-mgmt
>> MASTER_SITES=  LOCAL/bdrewery/${PORTNAME}/ \
>>                http://mirror.shatow.net/freebsd/${PORTNAME}/ \
>> @@ -24,9 +25,6 @@ PLIST_FILES=  sbin/portmaster \
>> BASH_PLIST_FILES=      etc/bash_completion.d/portmaster.sh
>> ZSH_PLIST_FILES=       share/zsh/site-functions/_portmaster
>> 
>> -BASH_RUN_DEPENDS=      bash>=0:${PORTSDIR}/shells/bash
>> -ZSH_RUN_DEPENDS=       zsh>=0:${PORTSDIR}/shells/zsh
>> -
>> verify: checksum
>> 
> 
> Does this break run dependency if a user chooses option of bash/zsh,
> as helper files will be installed, but
> bash/zsh won't be installed?

Yes, it does. But it's better without the dependencies.

The actual program itself works perfectly without bash or zsh. But then you install zsh one day and *poof* you get completions. Removing zsh shouldn't deinstall portmaster, upgrading zsh shouldn't reinstall portmaster, and errors in the zsh port shouldn't prevent portmaster packages from being produced.

The bigger problem is that the completions aren't enabled by default. Ports should do what pkg does: install completions as part of the default package.

My car is capable of pairing with Android phones and iPhones, but that doesn't mean it needs to include an Android phone and an iPhone when you buy the car.

# Adam


-- 
Adam Weinberger
adamw at adamw.org
http://www.adamw.org