svn commit: r408737 - head/ports-mgmt/portmaster

[Mathieu Arnold]

+--On 12 février 2016 10:01:48 -0800 Jason Helfman <jgh at FreeBSD.org> wrote:
| On Fri, Feb 12, 2016 at 7:46 AM, Mathieu Arnold <mat at freebsd.org> wrote:
|> Author: mat
|> Date: Fri Feb 12 15:46:04 2016
|> New Revision: 408737
|> URL: https://svnweb.freebsd.org/changeset/ports/408737
|> 
|> Log:
|>   Remove unneeded dependencies on bash and zsh.
|> 
|>   With hat:     portmgr
|>   Sponsored by: Absolight
|> 
|> Modified:
|>   head/ports-mgmt/portmaster/Makefile
|> 
|> Modified: head/ports-mgmt/portmaster/Makefile
|> ========================================================================
|> ====== --- head/ports-mgmt/portmaster/Makefile Fri Feb 12 15:34:10 2016
|> (r408736) +++ head/ports-mgmt/portmaster/Makefile Fri Feb 12 15:46:04
|> 2016        (r408737) @@ -2,6 +2,7 @@
|> 
|>  PORTNAME=      portmaster
|>  PORTVERSION=   3.17.9
|> +PORTREVISION=  1
|>  CATEGORIES=    ports-mgmt
|>  MASTER_SITES=  LOCAL/bdrewery/${PORTNAME}/ \
|>                 http://mirror.shatow.net/freebsd/${PORTNAME}/ \
|> @@ -24,9 +25,6 @@ PLIST_FILES=  sbin/portmaster \
|>  BASH_PLIST_FILES=      etc/bash_completion.d/portmaster.sh
|>  ZSH_PLIST_FILES=       share/zsh/site-functions/_portmaster
|> 
|> -BASH_RUN_DEPENDS=      bash>=0:${PORTSDIR}/shells/bash
|> -ZSH_RUN_DEPENDS=       zsh>=0:${PORTSDIR}/shells/zsh
|> -
|>  verify: checksum
|> 
| 
| Does this break run dependency if a user chooses option of bash/zsh,
| as helper files will be installed, but
| bash/zsh won't be installed?

The BASH/ZSH options install completions files, having portmaster depend on
bash or zsh is silly, portmaster does not need either to run.  If the user
wants to use bash completions, he's certainly already using bash and has it
installed.

Also, I don't know how exactly zsh works, but for bash, the dependency was
wrong anyway, for it to work, you need the shells/bash-completion port.

-- 
Mathieu Arnold
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 949 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20160212/5656a1ed/attachment.sig>