svn commit: r341219 - in head/www: xpi-twitterfox xpi-unplug xpi-urllink xpi-user_agent_switcher xpi-vimperator

[Renato Botelho]

On 26-01-2014 17:14, Andrej Zverev wrote:
> On Sun, Jan 26, 2014 at 10:06 PM, Renato Botelho <garga at freebsd.org> wrote:
>> On 26-01-2014 13:23, Andrej Zverev wrote:
>>> On Sun, Jan 26, 2014 at 7:14 PM, Martin Wilke <miwi at freebsd.org> wrote:
>>>> Author: miwi
>>>> Date: Sun Jan 26 15:14:34 2014
>>>> New Revision: 341219
>>>> URL: http://svnweb.freebsd.org/changeset/ports/341219
>>>> QAT: https://qat.redports.org/buildarchive/r341219/
>>>>
>>>> Log:
>>>>   - Stage support
>>>>
>>>>
>>>> Modified: head/www/xpi-unplug/Makefile
>>>> ==============================================================================
>>>> --- head/www/xpi-unplug/Makefile        Sun Jan 26 15:14:03 2014        (r341218)
>>>> +++ head/www/xpi-unplug/Makefile        Sun Jan 26 15:14:34 2014        (r341219)
>>>> @@ -12,7 +12,6 @@ COMMENT=      Converts embedded media to html
>>>>  XPI_ID=                unplug at compunach
>>>>  XPI_NUM=       2254
>>>>
>>>> -NO_STAGE=      yes
>>>>  xpi-post-extract:
>>>>         ${FIND} ${WRKSRC} -type d -name CVS|${XARGS} ${RM} -rf
>>>>
>>>>
>>>> Modified: head/www/xpi-urllink/Makefile
>>>
>>>
>>> Can you at least run portlint and fix easy warnings in such commits? like
>>> "WARN: Makefile: [17]: possible use of "${FIND} ... ${XARGS} ${RM}"
>>> when "${FIND} ... -delete" will work"
>>
>> find -delete won't delete a not empty directory. And this find is only
>> looking for directories.
> 
> While this is true, but distfile itself does not contain any CVS
> directories in this case ;-)
> 'easy fix'

Now you have a good point :)

-- 
Renato Botelho <garga     @ FreeBSD.org>
               <garga.bsd @ gmail.com>
GnuPG Key: http://www.FreeBSD.org/~garga/pubkey.asc

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 924 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20140126/4a0bc9a8/attachment.sig>