svn commit: r341219 - in head/www: xpi-twitterfox xpi-unplug xpi-urllink xpi-user_agent_switcher xpi-vimperator

Andrej Zverev az at freebsd.org
Sun Jan 26 19:14:46 UTC 2014


On Sun, Jan 26, 2014 at 10:06 PM, Renato Botelho <garga at freebsd.org> wrote:
> On 26-01-2014 13:23, Andrej Zverev wrote:
>> On Sun, Jan 26, 2014 at 7:14 PM, Martin Wilke <miwi at freebsd.org> wrote:
>>> Author: miwi
>>> Date: Sun Jan 26 15:14:34 2014
>>> New Revision: 341219
>>> URL: http://svnweb.freebsd.org/changeset/ports/341219
>>> QAT: https://qat.redports.org/buildarchive/r341219/
>>>
>>> Log:
>>>   - Stage support
>>>
>>>
>>> Modified: head/www/xpi-unplug/Makefile
>>> ==============================================================================
>>> --- head/www/xpi-unplug/Makefile        Sun Jan 26 15:14:03 2014        (r341218)
>>> +++ head/www/xpi-unplug/Makefile        Sun Jan 26 15:14:34 2014        (r341219)
>>> @@ -12,7 +12,6 @@ COMMENT=      Converts embedded media to html
>>>  XPI_ID=                unplug at compunach
>>>  XPI_NUM=       2254
>>>
>>> -NO_STAGE=      yes
>>>  xpi-post-extract:
>>>         ${FIND} ${WRKSRC} -type d -name CVS|${XARGS} ${RM} -rf
>>>
>>>
>>> Modified: head/www/xpi-urllink/Makefile
>>
>>
>> Can you at least run portlint and fix easy warnings in such commits? like
>> "WARN: Makefile: [17]: possible use of "${FIND} ... ${XARGS} ${RM}"
>> when "${FIND} ... -delete" will work"
>
> find -delete won't delete a not empty directory. And this find is only
> looking for directories.

While this is true, but distfile itself does not contain any CVS
directories in this case ;-)
'easy fix'


More information about the svn-ports-all mailing list