svn commit: r316515 - head/graphics/gdk-pixbuf2

[Alex Kozlov]

On Fri, Apr 26, 2013 at 03:51:32AM +0000, Alexey Dokuchaev wrote:
> On Thu, Apr 25, 2013 at 01:44:39PM +0000, Alex Kozlov wrote:
> > New Revision: 316515
> > URL: http://svnweb.freebsd.org/changeset/ports/316515
> > 
> > <...>
> >   - Remove NLS from options, it's handled globally
> 
> It looks like we do need a policy on this issue.  Recently it was discussed
> (google for "Re: svn commit: r315222") again for example.
Some guidelines would be nice to have.
 
> I personally think that all options should be listed in OPTIONS_DEFINE, even
> the global ones.  The nice thing here that if some option(s) will migrate
> their local<->global status, we would not have to change OPTIONS_DEFINE in
> thousands places across the tree.  It would also mean no diversity; right
> now some people list them, while some don't.
I personally think that global options should not be generally listed,
but maintainer should have the last word.
 
> As for addressing the annoyance part of the question, it should be solved
> with separate knob, settable in /etc/make.conf, that users can set to skip
> the global options in dialog (or disable skipping if it's on by default).
> OPTIONS_DEFINE should not be abused for this purpose.
Perhaps, but I prefer knob which adds global options to dialog.


-- 
Alex