svn commit: r316515 - head/graphics/gdk-pixbuf2

Alexey Dokuchaev danfe at FreeBSD.org
Fri Apr 26 03:51:33 UTC 2013


On Thu, Apr 25, 2013 at 01:44:39PM +0000, Alex Kozlov wrote:
> New Revision: 316515
> URL: http://svnweb.freebsd.org/changeset/ports/316515
> 
> <...>
>   - Remove NLS from options, it's handled globally

It looks like we do need a policy on this issue.  Recently it was discussed
(google for "Re: svn commit: r315222") again for example.

I personally think that all options should be listed in OPTIONS_DEFINE, even
the global ones.  The nice thing here that if some option(s) will migrate
their local<->global status, we would not have to change OPTIONS_DEFINE in
thousands places across the tree.  It would also mean no diversity; right
now some people list them, while some don't.

As for addressing the annoyance part of the question, it should be solved
with separate knob, settable in /etc/make.conf, that users can set to skip
the global options in dialog (or disable skipping if it's on by default).
OPTIONS_DEFINE should not be abused for this purpose.

./danfe


More information about the svn-ports-all mailing list