Week 1 Update: Mergesort Tests
Miles Fertel
milesfertel at college.harvard.edu
Tue Jun 6 07:58:28 UTC 2017
Made it public!
Here's the review:
https://github.com/milesfertel/GSOC-Mergesort/pull/1/commits/9297e92f08a7f318ec3e6e2e2377d78bfa763dbf
I'm not sure if you'll see the comments on the pull request unless you're
logged in. Let me know if that's a problem.
-Miles
On Tue, Jun 6, 2017 at 2:41 AM, Brooks Davis <brooks at freebsd.org> wrote:
> I got an invite from github, but even when I was definitely logged in, I
> got 404 errors accessing it.
>
> As a practical matter, your repo needs to be public as that's part of the
> terms from Google.
>
> -- Brooks
>
> On Mon, Jun 05, 2017 at 09:53:00AM -0400, Miles Fertel wrote:
> > Hey Brooks,
> >
> > Just wanted to let you know that I've pushed my first week of work to the
> > github repo and added you as a collaborator. I've submitted a pull
> request
> > from the dev branch to the master and started a review with a question or
> > two.
> >
> > I've edited mergesort_test.c to have a good first implementation,
> including
> > tests for:
> >
> > - Trivial arrays
> > - Sorted arrays
> > - Partially sorted arrays
> > - Randomly generated arrays
> > - Arrays with char elements
> >
> > I've built this up on top of the previous implementation, so the Kyuafile
> > is the same. I ran the implementation locally with atf and kyua and the
> > current mergesort behaves as expected, succeeding all all tests except
> for
> > the small element test. When my improved algorithm is complete, that
> should
> > pass as well.
> >
> > Please let me know if there's anything I could improve.
> >
> > - Miles
>
More information about the soc-status
mailing list