Week 1 Update: Mergesort Tests

Brooks Davis brooks at freebsd.org
Tue Jun 6 00:41:38 UTC 2017


I got an invite from github, but even when I was definitely logged in, I
got 404 errors accessing it.

As a practical matter, your repo needs to be public as that's part of the
terms from Google.

-- Brooks

On Mon, Jun 05, 2017 at 09:53:00AM -0400, Miles Fertel wrote:
> Hey Brooks,
> 
> Just wanted to let you know that I've pushed my first week of work to the
> github repo and added you as a collaborator. I've submitted a pull request
> from the dev branch to the master and started a review with a question or
> two.
> 
> I've edited mergesort_test.c to have a good first implementation, including
> tests for:
> 
>    - Trivial arrays
>    - Sorted arrays
>    - Partially sorted arrays
>    - Randomly generated arrays
>    - Arrays with char elements
> 
> I've built this up on top of the previous implementation, so the Kyuafile
> is the same. I ran the implementation locally with atf and kyua and the
> current mergesort behaves as expected, succeeding all all tests except for
> the small element test. When my improved algorithm is complete, that should
> pass as well.
> 
> Please let me know if there's anything I could improve.
> 
> - Miles
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 455 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/soc-status/attachments/20170606/4d1a4646/attachment.sig>


More information about the soc-status mailing list