Another blkback issue related to flush

Roger Pau Monné roger.pau at citrix.com
Wed Sep 4 18:03:55 UTC 2013


On 04/09/13 19:49, Justin T. Gibbs wrote:
> On Sep 4, 2013, at 11:07 AM, Roger Pau Monné <roger.pau at citrix.com> wrote:
> 
>> Hello,
>> 
>> I've found another issue with blkback handling of flush operations, it
>> was incorrectly setting one of the bio parameters when using a block
>> device as backend. The attached patch fixes it, and also includes a
>> small fix to correctly set the operation when writing the response on
>> the ring (all responses written by FreeBSD blkback were of type
>> BLKIF_OP_READ, because nreq->operation was not set).
> 
> It seems that the req's pendcnt is unused and can be culled.  Otherwise,
> looks good to me.  Here's the patch I have in my tree now.

Thanks for catching this one. The patch looks OK to me.



More information about the freebsd-xen mailing list