Another blkback issue related to flush
Justin T. Gibbs
gibbs at freebsd.org
Wed Sep 4 17:49:40 UTC 2013
On Sep 4, 2013, at 11:07 AM, Roger Pau Monné <roger.pau at citrix.com> wrote:
> Hello,
>
> I've found another issue with blkback handling of flush operations, it
> was incorrectly setting one of the bio parameters when using a block
> device as backend. The attached patch fixes it, and also includes a
> small fix to correctly set the operation when writing the response on
> the ring (all responses written by FreeBSD blkback were of type
> BLKIF_OP_READ, because nreq->operation was not set).
It seems that the req's pendcnt is unused and can be culled. Otherwise,
looks good to me. Here's the patch I have in my tree now.
--
Justin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: blkback.diff
Type: application/octet-stream
Size: 1984 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/freebsd-xen/attachments/20130904/7840c964/attachment.obj>
-------------- next part --------------
More information about the freebsd-xen
mailing list