xf86-video-ati-legacy fails to compile

[Niclas Zeising]

See the mail titled Users of x11-drivers/xf86-video-ati-legacy for details.
Can be found here:
https://lists.freebsd.org/pipermail/freebsd-x11/2020-February/025103.html
There is an untested patch here:
https://reviews.freebsd.org/D23817

Regards
Niclas

On 2020-02-24 21:21, Robert Huff wrote:
> 
> 	On a system running:
> 
> FreeBSD 13.0-CURRENT #0 r354131: Mon Oct 28 17:27:33 EDT 2019  amd64
> 
> 	with the ports tree updated nightly, xf86-video-ati-legacy has
> failed to compile since the most recent update.
> 	The error message is:
> 
> --- radeon_drm_queue.lo ---
> mv -f .deps/radeon_drm_queue.Tpo .deps/radeon_drm_queue.Plo
> --- radeon_sync.lo ---
> /bin/sh ../libtool  --tag=CC    --mode=compile cc -DHAVE_CONFIG_H  -I. -I..   -Wall  -I/usr/local/include -I/usr/local/include/libdrm  -I/usr/local/include/xorg -fvisibility=hidden -I/usr/local/include -I/usr/local/include/pixman-1 -I/usr/local/include/X11/dri -I/usr/local/include/libdrm  -I/usr/local/include     -O2 -pipe  -Werror=uninitialized -fstack-protector-strong -fno-strict-aliasing -MT radeon_sync.lo -MD -MP -MF .deps/radeon_sync.Tpo -c -o radeon_sync.lo radeon_sync.c
> --- radeon_present.lo ---
> libtool: compile:  cc -DHAVE_CONFIG_H -I. -I.. -Wall -I/usr/local/include -I/usr/local/include/libdrm -I/usr/local/include/xorg -fvisibility=hidden -I/usr/local/include -I/usr/local/include/pixman-1 -I/usr/local/include/X11/dri -I/usr/local/include/libdrm -I/usr/local/include -O2 -pipe -Werror=uninitialized -fstack-protector-strong -fno-strict-aliasing -MT radeon_present.lo -MD -MP -MF .deps/radeon_present.Tpo -c radeon_present.c  -fPIC -DPIC -o .libs/radeon_present.o
> --- radeon_kms.lo ---
> radeon_kms.c:546:51: error: no member named 'drawable' in 'struct _Drawable'
>          ScrnInfoPtr pScrn = xf86ScreenToScrn(dirty->src->drawable.pScreen);
>                                               ~~~~~~~~~~  ^
> radeon_kms.c:579:43: error: no member named 'master_pixmap' in 'struct _Drawable'
>      ScreenPtr master_screen = dirty->src->master_pixmap->drawable.pScreen;
>                                ~~~~~~~~~~  ^
> radeon_kms.c:584:21: warning: comparison of distinct pointer types ('PixmapPtr' (aka 'struct _Pixmap *') and 'DrawablePtr' (aka 'struct _Drawable *')) [-Wcompare-distinct-pointer-types]
>          if (ent->slave_dst != dirty->src)
>              ~~~~~~~~~~~~~~ ^  ~~~~~~~~~~
> radeon_kms.c:599:43: error: no member named 'master_pixmap' in 'struct _Drawable'
>      ScreenPtr master_screen = dirty->src->master_pixmap->drawable.pScreen;
>                                ~~~~~~~~~~  ^
> radeon_kms.c:615:43: error: no member named 'master_pixmap' in 'struct _Drawable'
>      ScreenPtr master_screen = dirty->src->master_pixmap->drawable.pScreen;
>                                ~~~~~~~~~~  ^
> radeon_kms.c:679:17: warning: comparison of distinct pointer types ('DrawablePtr' (aka 'struct _Drawable *') and 'PixmapPtr' (aka 'struct _Pixmap *')) [-Wcompare-distinct-pointer-types]
>          if (dirty->src == scanoutpix && dirty->slave_dst ==
>              ~~~~~~~~~~ ^  ~~~~~~~~~~
> radeon_kms.c:835:41: error: no member named 'master_pixmap' in 'struct _Drawable'
>                                  ScreenPtr master_screen = ent->src->master_pixmap->drawable.pScreen;
>                                                            ~~~~~~~~  ^
> radeon_kms.c:838:32: warning: comparison of distinct pointer types ('PixmapPtr' (aka 'struct _Pixmap *') and 'DrawablePtr' (aka 'struct _Drawable *')) [-Wcompare-distinct-pointer-types]
>                                          if (region_ent->slave_dst == ent->src)
>                                              ~~~~~~~~~~~~~~~~~~~~~ ^  ~~~~~~~~
> 3 warnings and 5 errors generated.
> *** [radeon_kms.lo] Error code 1
> 
> 	I have re-built all dependencies without problem.
> 	This may be my fault; don't care.  What do I do to fix this?
> 
> 
> 			Respectfully,
> 
> 
> 				Robert Huff
> 
> 
> 	
> _______________________________________________
> freebsd-x11 at freebsd.org mailing list
> https://lists.freebsd.org/mailman/listinfo/freebsd-x11
> To unsubscribe, send any mail to "freebsd-x11-unsubscribe at freebsd.org"
> 


-- 
Niclas Zeising