[Differential] D13995: NVMe controller emulator for bhyve.

[cem (Conrad Meyer)]

cem added a reviewer: imp.
cem added a comment.


  Awesome!
  
  I can't speak to the NVMe emulation itself (I know almost nothing about the protocol and nothing about Bhyve HW emu interfaces).  Maybe Warner can.

INLINE COMMENTS

> nvme.h:127
>  enum shn_value {
> +    NVME_SHN_NOEFCT     = 0x0,
>  	NVME_SHN_NORMAL		= 0x1,

indentation looks off here.  is it just phabricator?

> Makefile:65
>  
> -CFLAGS+= -I${BHYVE_SYSDIR}/sys/dev/usb/controller
> +CFLAGS+= -I${BHYVE_SYSDIR}/sys/dev/usb/controller -I${BHYVE_SYSDIR}/sys/dev/nvme/
>  

don't need trailing slash

> pci_nvme.c:19
> +#ifdef NVME_DEBUG
> +static FILE* dbg;
> +#define DPRINTF(format, arg...)      \

style nit: `static FILE *dbg;` (asterisk goes on the right side of the space)

> pci_nvme.c:21
> +#define DPRINTF(format, arg...)      \
> +    do {                             \
> +        fprintf(dbg, format, ##arg); \

style nit: Should be tab indents throughout (can't tell if that's just Phab making it look like 4 spaces or actually 4 spaces).

REVISION DETAIL
  https://reviews.freebsd.org/D13995

EMAIL PREFERENCES
  https://reviews.freebsd.org/settings/panel/emailpreferences/

To: sux2mfgj_gmail.com, grehan, trasz, imp
Cc: cem, freebsd-virtualization-list, chuck